-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Amino #265
remove Amino #265
Conversation
Amino can be removed from the proofs. This will affect the Think #276 should be merged after this PR, and Please confirm @ethanfrey |
As to ics23 proofs, we allow a spec to length-prefix data many ways. Ideally the output of |
It looks like
So this shouldn't even be an issue for IavlSpec (but please test) |
I would also say that once #276 is merged and deeply integrated (in a separate PR?) to access the store rather than translating exisiting proofs, you may wish to remove the custom amino-style proof format. How are RangeProofs serialized? Maybe not in this module, but in the sdk they are only serialized using amino before hitting the wire on sdk queries. |
92f18f1
to
051ce8f
Compare
Following discussions in a call last week with @AdityaSripal and @alexanderbez, we'll keep the current proofs along with the new proofs, but try to migrate them to Protobuf if we are able to keep byte-compatibility. I'll do that in a separate PR, so this PR is good to review and merge. |
fa523d4
to
560510c
Compare
Removes Amino and adds varint utility-functions instead, keeping the same serialized format. Partial fix for #242.
The last vestige of Amino is in the proof handling, namely
AbsenceOp
andValueOp
, which are structs encoded/decoded with Amino.